fix: handle newlines in SSE events to prevent content truncation #21#22
Open
alekseysotnikov wants to merge 1 commit intodynamic-alpha:mainfrom
Open
Conversation
rschmukler
approved these changes
Mar 12, 2026
Contributor
rschmukler
left a comment
rschmukler
left a comment
There was a problem hiding this comment.
Thanks. Will squash and merge asap.
When HTML content contains newline characters (\n), the SSE event formatting was not escaping them properly. This caused SSE events to be prematurely terminated, resulting in truncated content on the client side during live-reload updates. Root cause: format-datastar-fragment was outputting HTML directly in a single 'data: elements' line without handling newlines. Any \n\n in the HTML would prematurely end the SSE event according to the SSE spec. Fix: Split HTML by \n and emit multiple 'data: elements' lines, which Datastar concatenates. This follows Datastar's documented multi-line SSE format and prevents \n\n from breaking the event stream. Tests added: - Unit tests for textarea and pre elements with newline content - E2E test for content with newlines during route redefinition
alekseysotnikov
force-pushed
the
#21-SSE-Event-Truncation-with-Newlines-in-HTML
branch
from
87edb32 to
d565e35
Compare
Contributor
Author
|
Thank you for instant feedback! I have squashed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When HTML content contains newline characters (
\n), the SSE event formatting was not escaping them properly. This caused SSE events to be prematurely terminated, resulting in truncated content on the client side during live-reload updates.Root cause:
format-datastar-fragmentwas outputting HTML directly in a singledata: elementsline without handling newlines. Any\nin the HTML would prematurely end the SSE event.Fix: Split HTML by
\nand emit multipledata: elementslines, which Datastar concatenates. This follows Datastar's documented multi-line SSE format and prevents\nfrom breaking the event stream. #21